feat: add exactOptional support in type struct#38
Merged
Conversation
exactOptional support in type struct
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e49b9ff. Configure here.
exactOptional support in type structexactOptional support in type struct
hmalik88
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support of
exactOptionalwithsuperstruct.type.We plan to use
@metamask/superstructin@metamask/keyring-apiand we already use the combotype+exactOptional(our implementation) there.Note
Low Risk
Small, localized change to
type()entry iteration aligned with existingobject()semantics; covered by new tests with no auth or data-path impact.Overview
Extends
type()soexactOptional()fields behave like TypeScript’s optional properties: the key may be missing, but an explicitundefinedvalue is still validated and rejected.The
type()entriesgenerator now skips properties wrapped inexactOptionalwhen the key is not on the object (hasOwnProperty), matching the existingobject()behavior.Adds typing coverage for
type+exactOptional, plus validation fixtures for absent keys, present values, andage: undefinedfailing validation.Reviewed by Cursor Bugbot for commit e49b9ff. Bugbot is set up for automated code reviews on this repo. Configure here.